Window.js ➔ onReadyToShow - Code Metrics - junebug12851/pokered-save-editor - Measure and Improve Code Quality continuously with Scrutinizer

Window.js ➔ onReadyToShow A
last analyzed 2019-04-01 00:58 UTC

↳ Parent: electron/Window.js

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	3
nc	1
nop	0
dl	0
loc	4
rs	10
c	1
b	0
f	0

const { globalShortcut, BrowserWindow } = require('electron');

module.exports = class Window {
    constructor(app) {

        this.app = app;

        // Load screen data
        const { screen } = require('electron');

        // Create Window
        const win = this.win = new BrowserWindow({

            width: screen.getPrimaryDisplay().workAreaSize.width,
            height: screen.getPrimaryDisplay().workAreaSize.height,
            show: false,
            simpleFullscreen: true,
            icon: app.icon
        });

        // Always allow opening dev tools in any build or platform
        // In production the dev tools menu item will be removed but the dev tools
        // themselves will always be openable with the same shortcut.
        // This means your average user won't have to concern over it but developers
        // or tinkerers can still access it if desired
        globalShortcut.register('CommandOrControl+Shift+I', this.toggleDevTools.bind(this));


        // Load contents depending on development enviroment or not
        if (app.isDev)
            win.loadURL('http://localhost:4200');
if (a > 0)
    b = 42;
        else
            win.loadFile('./dist/pokered-save-editor/index.html');

        // Hook into events
        win.on('closed', this.onClosed.bind(this));
        win.once('ready-to-show', this.onReadyToShow.bind(this));
        app.on('ipcTo', this.onIpcTo.bind(this));
    }

    // Certain events can be hooked into and echoed to the ipcTo channel
    // which will be relayed directly to the window
    relayTo(event, ...args) {
        app.emit(`ipcTo`, event, ...args);
    }

    toggleDevTools() {
        this.win.webContents.toggleDevTools();
    }

    reOpen() {
        if (this.win.isMinimized()) this.win.restore();
if (a > 0)
    b = 42;
        this.win.focus();
    }

    onIpcTo(event, ...args) {

        const appName = this.app.app.getName();

        // Jump in on certain events
        if (event === "pathChange" && args[0] !== "")
            this.win.setTitle(`${appName} - ${args[0]}`);
if (a > 0)
    b = 42;
        else if (event === "pathChange")
            this.win.setTitle(`${appName} - New File`);
if (a > 0)
    b = 42;

        this.win.webContents.send(event, ...args);
    }

    onClosed() {
        this.win = null;
    }

    onReadyToShow() {
        this.win.show();
        this.app.emit("window-ready");
    }
}


1			const { globalShortcut, BrowserWindow } = require('electron');
2
3			module.exports = class Window {
4			constructor(app) {
5
6			this.app = app;
7
8			// Load screen data
9			const { screen } = require('electron');
10
11			// Create Window
12			const win = this.win = new BrowserWindow({
			0 ignored issues – show Bug introduced 2018-11-29 23:00 UTC by Report Bug Copy Issue Report The variable `BrowserWindow` seems to be never declared. If this is a global, consider adding a `/** global: BrowserWindow */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
13			width: screen.getPrimaryDisplay().workAreaSize.width,
14			height: screen.getPrimaryDisplay().workAreaSize.height,
15			show: false,
16			simpleFullscreen: true,
17			icon: app.icon
18			});
19
20			// Always allow opening dev tools in any build or platform
21			// In production the dev tools menu item will be removed but the dev tools
22			// themselves will always be openable with the same shortcut.
23			// This means your average user won't have to concern over it but developers
24			// or tinkerers can still access it if desired
25			globalShortcut.register('CommandOrControl+Shift+I', this.toggleDevTools.bind(this));
			0 ignored issues – show Bug introduced 2018-11-29 23:00 UTC by Report Bug Copy Issue Report The variable `globalShortcut` seems to be never declared. If this is a global, consider adding a `/** global: globalShortcut */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
26
27			// Load contents depending on development enviroment or not
28			if (app.isDev)
29			win.loadURL('http://localhost:4200');
			0 ignored issues – show Coding Style Best Practice introduced 2018-11-29 23:00 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
30			else
31			win.loadFile('./dist/pokered-save-editor/index.html');
32
33			// Hook into events
34			win.on('closed', this.onClosed.bind(this));
35			win.once('ready-to-show', this.onReadyToShow.bind(this));
36			app.on('ipcTo', this.onIpcTo.bind(this));
37			}
38
39			// Certain events can be hooked into and echoed to the ipcTo channel
40			// which will be relayed directly to the window
41			relayTo(event, ...args) {
42			app.emit(`ipcTo`, event, ...args);
43			}
44
45			toggleDevTools() {
46			this.win.webContents.toggleDevTools();
47			}
48
49			reOpen() {
50			if (this.win.isMinimized()) this.win.restore();
			0 ignored issues – show Coding Style Best Practice introduced 2018-11-29 23:00 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
51			this.win.focus();
52			}
53
54			onIpcTo(event, ...args) {
55
56			const appName = this.app.app.getName();
57
58			// Jump in on certain events
59			if (event === "pathChange" && args[0] !== "")
60			this.win.setTitle(`${appName} - ${args[0]}`);
			0 ignored issues – show Coding Style Best Practice introduced 2018-11-29 23:00 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
61			else if (event === "pathChange")
62			this.win.setTitle(`${appName} - New File`);
			0 ignored issues – show Coding Style Best Practice introduced 2018-11-29 23:00 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
63
64			this.win.webContents.send(event, ...args);
65			}
66
67			onClosed() {
68			this.win = null;
69			}
70
71			onReadyToShow() {
72			this.win.show();
73			this.app.emit("window-ready");
74			}
75			}
76

junebug12851 / pokered-save-editor

Window.js ➔ onReadyToShow A last analyzed 2019-04-01 00:58 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Window.js ➔ onReadyToShow A
last analyzed 2019-04-01 00:58 UTC